Prod proxy support #993
Merged
Prod proxy support #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbetts-godaddy
approved these changes
Dec 17, 2024
agerard-godaddy
approved these changes
Dec 17, 2024
Co-authored-by: Andrew Gerard <[email protected]>
agerard-godaddy
added a commit
that referenced
this pull request
Dec 18, 2024
* Fix Gasket imports w/tsconfig alias * Opt for gasket-data.js * Tune local watcher for TS default server * Add concurrently dep * Tune Ts plugin tests * tests and linter * tune local script for custom server * fix test * Update packages/gasket-plugin-nextjs/lib/create.js Co-authored-by: Andrew Gerard <[email protected]> * fix test --------- Co-authored-by: Andrew Gerard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tuning to allow for the new
gasket-plugin-https-proxyto be implemented correctly. Proxies we're never considered in the production use case so now we can allow for a proxy setup in non-local situations.gasket-datato.jsfor app variations@/gasketalias in TS scenarioslocalscripts to correctly rebuild thedistfolder (issue with Page Router Default Server where thedistdirectory changes doesn't cause a reload innext devbut it works in app router 🤷♂️ Ticket to be created).concurrentlyforlocalscript reloadinglocalscript for all server typesChangelog
gasket-plugin-https-proxyto be implemented correctly for prod use casesTest Plan
Tests updated